Thanks a lot for taking the initiative!
Your proposal makes sense; I wonder though if we should not use the
master branch directly for SFML 3, and maintain a separate
sfml2 branch for a while.
I think there are mainly two categories of SFML users:
- Those who want a stable version -- they usually stick to official releases.
- Those who want the latest features -- they use master.
The problem I see with a separate
sfml3 branch, is that it will get next to no exposure, meaning less feedback and less testing. But I'm open to hear other team members' opinions here.
Regarding
sf::Angle in particular, it may seem like a small reasonable improvement, but it's 1. a breaking change, so cannot be merged to SFML 2 even if everyone agreed, and 2. not uncontroversial -- many gamedev libraries and game engines stick to floats and a fixed convention (radian/degree). But generally, I get your point with the lack of progress.
What I would appreciate regarding contributions, is that pull requests are reasonably sized. We can make an exception for
the initial one, but if possible let's not add even more to this one. The risk of big PRs is that it becomes a daunting task to review, and people are scared off if they have to invest multiple hours just to go through the code -- which is exactly what we don't want
Also, would it be possible to merge dozens of commits to one, or a few, with meaningful commit messages? That would also help understanding a lot