Little surface class

[BloodGod]

Hi =)

I've coded a little surface class, ok it's a class that stores a set of sf:Sprites  :roll: :

Code: [Select]


#include <vector>
#include <SFML/Graphics.hpp>

class Surface
{
      std::vector<sf::Sprite> m_sprites;
   public:
      void Add(sf::Sprite &s);
      void Clear();
      void Display(sf::RenderWindow& rw) const;
      Surface();
      Surface(int reserve);
};

Surface::Surface()
{
}

Surface::Surface(int reserve)
{
   m_sprites.reserve(reserve);
}

void Surface::Add(sf::Sprite &s)
{
   m_sprites.push_back(s);
}
void Surface::Clear()
{
   m_sprites.clear();
}

void Surface::Display(sf::RenderWindow& rw) const
{
   for(unsigned int i = 0;i < m_sprites.size();i++)
      rw.Draw(m_sprites[i]);

   rw.Display();
}


usage:

Code: [Select]


     sf::Image Image;
     if (!Image.LoadFromFile("image.jpg"))
         return EXIT_FAILURE;
     sf::Sprite Sprite(Image);
     Surface surf;

     surf.Add(Sprite);
/*......*/
     surf.Display(App); //App -> sf::RenderWindow


I thought it will might be useful for someone. Be careful, the sprites are copied. That makes it possible to "draw" 1 Sprite onto different surfaces...

Maybe it would be a nice idea to make real surfaces :/
Sicerely,
BloodGod

[zarka]

a few tips on how you might want to change this.

change the Add method to take in a const sf::Sprite &s this is good since you avoid making several unnecessary copy constructor calls. (and also makes it more const correct)

you could also remove the member iterator m_it and use the push_back method in the vector.

to make this even more const correct you could make your Display function const to (since it does not change any data in the class)

Code: [Select]

void Display(const sf::RenderWindow& rw) const;

[BloodGod]

Hi =)

Thanks for the tip(I've changed the first post), but

Code: [Select]

void Surface::Display([color=red]const[/color] sf::RenderWindow& rw) const

does not work:

Code: [Select]


error: no matching function for call to `sf::RenderWindow::Display() const'


this works:

Code: [Select]

void Surface::Display(sf::RenderWindow& rw) const

Did I oversight something?

Sincerely,
BloodGod[/code]

[Laurent]

sf::RenderWindow is not const, so you can't call it if you have a const RenderWindow.

However, I'm not sure it's a good idea to call RenderWindow::Display in this function, as it's supposed to be called once per frame. This means you would use only one Surface instance in your program.

[zarka]

does not work:

Code: [Select]


error: no matching function for call to `sf::RenderWindow::Display() const'


this works:

Code: [Select]

void Surface::Display(sf::RenderWindow& rw) const
[/code]

aah i see. my bad i didn't really test the code before i submitted it... but ofcource if 6he const version does not work go with non const