delete sf::Window

[Anasky]

Hey all,

For memory purposes I am trying to delete the sf::Window variable I have. However, when I try to do so, I get the following error:

Debug Assertion Failed!

Program: C:\Windows\system32\MSVCP140D.dll
File: C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\xtree
Line: 237

Expression: map/set iterator not dereferencable

The code I use is the following:

int main(int argc, char *argv[]){
m_WindowMode = sf::VideoMode(1024, 768);
m_Title = "Brawler";
m_ContextSettings = sf::ContextSettings(24U, 8U, 4U, 3U, 1U, 0U);
m_Style = sf::Style::None;
m_Style |= sf::Style::Titlebar;
m_Style |= sf::Style::Resize;
m_Style |= sf::Style::Close;
//m_Style |= sf::Style::Fullscreen;
Window = new sf::Window();

delete Window;
return 0;
}

Does anyone happen to know why this is happening, and if there is a solution to it?

Thanks in advance,
Anasky

[Erdrick]

I see two things here.

It looks like the code you put in your message isn't complete, what object does m_Title etc. belong to?  Is there more code you should have included to help make sense of this example?

Secondly, why are using the new operator anyway instead of just declaring an object of type sf::Window?

[Laurent]

Expression: map/set iterator not dereferencable

... which involves you're using a std::map or std::set. So please show us your real code, it's just a waste of time otherwise.

[Anasky]

Sure. Didn't wanna pollute the post with unnecessary data, but apparently I left out critical information.

My class:

namespace OpenGLNamespace
{
   class clsOpenGL
   {
   public:
      clsOpenGL();
      ~clsOpenGL();
      void Init(int ScreenWidth, int ScreenHeight, std::string Filepath);
      void LoadResources();
      void Resize();
      static void CheckOGLerror();
   public:
      std::string                        Filepath;
      sf::Window*                        Window;
   public:
      int                              m_ScreenWidth;
      int                              m_ScreenHeight;
      std::string                        m_ShaderPath;
      sf::VideoMode                     m_WindowMode;
      std::string                        m_Title;
      sf::ContextSettings                  m_ContextSettings;
      sf::Uint32                        m_Style;
      sf::WindowHandle                  m_WindowHandle;
      std::map<std::string, clsShader*>      m_Shaders;
      RECT                           m_WindowBorder;
      clsCamera*                        m_Camera;
   };
};

Its Init function:

void clsOpenGL::Init(int a_ScreenWidth, int a_ScreenHeight, std::string a_Filepath)
   {
      m_ScreenWidth = a_ScreenWidth;
      m_ScreenHeight = a_ScreenHeight;
      Filepath = a_Filepath;
      // Initialize window, ~OpenGL deletes it
      m_WindowMode = sf::VideoMode(1024, 768);
      m_Title = "Brawler";
      m_ContextSettings = sf::ContextSettings(24U, 8U, 4U, 3U, 1U, 0U);
      m_Style = sf::Style::None;
      m_Style |= sf::Style::Titlebar;
      m_Style |= sf::Style::Resize;
      m_Style |= sf::Style::Close;
      //m_Style |= sf::Style::Fullscreen;
      Window = new sf::Window();
   }

Its destructor:

   clsOpenGL::~clsOpenGL()
   {
      delete Window;
   }

And the int main function:

int main(int argc, char *argv[])
{
   // OpenGL
   OpenGL.Init(Main.m_ScreenResolutionWidth, Main.m_ScreenResolutionHeight, Main.Filepath);

   // Clean up
   return 0;
}

The only map I can see is the m_Shaders, which isn't even being used in the current code.
Hopefully this is enough information to help out

Thanks in advance,
Anasky

[eXpl0it3r]

What's the stack track/call stack?

Why exactly are you manually allocating/deallocating the window?

[Hapax]

This code is still not complete.

For example, where is the creation of the OpenGL instance?

It might be wise for you to read this article (in particular, this section) to more easily allow people to help you.

[Anasky]

I must say, I look like a real fool now, lol.
Here is the call stack (crashes on ~Window(void)):

Code: [Select]

> msvcp140d.dll!std::_Debug_message(const wchar_t * message, const wchar_t * file, unsigned int line) Line 17 C++
  BrawlerEngine.exe!std::_Tree_const_iterator<class std::_Tree_val<struct std::_Tree_simple_types<class sf::priv::GlContext *> > >::operator*(void) Unknown
  BrawlerEngine.exe!sf::priv::GlContext::globalCleanup(void) Unknown
  BrawlerEngine.exe!sf::GlResource::~GlResource(void) Unknown
  BrawlerEngine.exe!sf::Window::~Window(void) Unknown
  BrawlerEngine.exe!sf::Window::`vector deleting destructor'(unsigned int) Unknown
  BrawlerEngine.exe!OpenGLNamespace::clsOpenGL::~clsOpenGL() Line 14 C++
  BrawlerEngine.exe!`dynamic atexit destructor for 'OpenGL''() C++
  ucrtbased.dll!__crt_scoped_stack_ptr<char>::__crt_scoped_stack_ptr<char>(struct __crt_scoped_stack_ptr_tag<char>) Unknown
  ucrtbased.dll!__crt_seh_guarded_call<int>::operator()<class <lambda_d22e02de4d14401f49897516b29a2b7c>,class <lambda_e971338317bfa523bb8920b43d823727> &,class <lambda_b0b8599c9027f5b14541fbbd6863d1f1> >(class <lambda_d22e02de4d14401f49897516b29a2b7c> &&,class <lambda_e971338317bfa523bb8920b43d823727> &,class <lambda_b0b8599c9027f5b14541fbbd6863d1f1> &&) Unknown
  ucrtbased.dll!__acrt_lock_and_call<class <lambda_e971338317bfa523bb8920b43d823727> >(enum __acrt_lock_id,class <lambda_e971338317bfa523bb8920b43d823727> &&) Unknown
  ucrtbased.dll!_execute_onexit_table() Unknown
  ucrtbased.dll!__crt_hmodule_traits::close(struct HINSTANCE__ *) Unknown
  ucrtbased.dll!exit() Unknown
  BrawlerEngine.exe!__scrt_common_main_seh() Line 266 C++
  BrawlerEngine.exe!__scrt_common_main() Line 300 C++
  BrawlerEngine.exe!mainCRTStartup() Line 17 C++
  kernel32.dll!BaseThreadInitThunk() Unknown
  ntdll.dll!RtlUserThreadStart() Unknown

If it's still not complete, I'm not sure what else to add. This is all the code that is being called, and the stacktrace is above.

As for creating the OpenGL instance, I haven't even reached that point yet. So far, I'm only trying to create and destroy a window.

[Hapax]

As for creating the OpenGL instance, I haven't even reached that point yet. So far, I'm only trying to create and destroy a window.

By OpenGL instance, I mean the OpenGL instance of your clsOpenGL object - the one on which you call Init.

[Anasky]

As for creating the OpenGL instance, I haven't even reached that point yet. So far, I'm only trying to create and destroy a window.

By OpenGL instance, I mean the OpenGL instance of your clsOpenGL object - the one on which you call Init.

My bad. It's a global instance.
Header:

extern OpenGLNamespace::clsOpenGL OpenGL;

CPP:

OpenGLNamespace::clsOpenGL OpenGL;

Its constructor only states:

        clsOpenGL::clsOpenGL()
        {
                Window = 0;
        }

[Hapax]

Don't construct SFML resources at global scope.

[Anasky]

Don't construct SFML resources at global scope.

Which is why it's a pointer. That way it'll be constructed inside int main(), at the call of Window = new sf::Window();

[Hapax]

When will it be destroyed?

The other SFML objects inside that class will be created as globals, including your map of shaders.

[Anasky]

When will it be destroyed?

The other SFML objects inside that class will be created as globals, including your map of shaders.

My shader class contains no SFML objects, only GLuint, ints, strings, and ints.
It'll be destroyed at the end of the application, when clsOpenGL's destructor is called, at which point 'delete Window;' is executed, and crashes.

EDIT: Found the issue. I moved the delete function to somewhere inside my own code (instead of the destructor of a global class), and it works.
Thanks hapax