SFML Light System - Let There Be Light

[kralo9]

EDIT: I fixed it! It's working fine now. It turns out m_lightAttenuationShader.unbind(); was important. I replaced it with:

Code: [Select]

//this is the replacement for unbind
sf::priv::GlContext::ensureContext();
glCheck(glUseProgramObjectARB(0));

since the unbind function was removed in this commit: https://github.com/SFML/SFML/commit/121cfeb6a3685e2529b717d5667ee6601533c30e

I can't call function glCheck(glUseProgramObjectARB(0));
Where is it implemented?

[Laurent]

With recent sources you can now call sf::Shader::bind(NULL) instead.

[kralo9]

Amazin. Actually with latest sources unbind() is available and working too. But I got a new problem. When im calling SetCenter() on a ltbl::light_point the program seems to crash as soon as I move a light long distances. For example from 0,0 to 800,400 (immediatly).

What may cause that problem?
Removing that call to the function makes the program uncrashable, but this is not what I'm looking for.

[Laurent]

Actually with latest sources unbind() is available and working too

Hmmm... no?

But I got a new problem. When im calling SetCenter() on a ltbl::light_point the program seems to crash as soon as I move a light long distances. For example from 0,0 to 800,400 (immediatly).

You're trying to move your light faster than the speed of light, it creates a wormhole in the universe which obviously makes your program crash.
Seriously? I have no idea, but it's not a SFML bug. Moving something doesn't do anything critical, just assigning a few floats. And for SFML there's no difference between a small move and a big move.

[kralo9]

Hm. Maybe I downloaded somehow wrong version of sfml2... where do I really download the latest sources?? :/
Maybe this causes the problem too.
Sorry if I'm too stupid for that.

Github or sfml homepage? I tried sfml2rc...
Github is a bit confusing me because it is not handy enough for me

[natchos]

Excuse me if this sounds dumb, but with the the version of SFML I have(downloaded a week or so ago) sf::shader::bind() can no longer be called with no arguments. Should I replace all calls to bind with no arguments with bind(NULL)?

[Laurent]

Build the API documentation, and read it

// bind a shader
sf::Shader::bind(&shader);

// bind nothing
sf::Shader::bind(NULL);

[kralo9]

I dont want to be inpolite, but in my opinion you cant be sure if that what you downloaded is really the latest version. Seems like I am not the only one having problems with that. Some explicit hints/links to the latest sources would be great. I would find 2 different downloads of SFML2 (like it seels to be) in the download section on the sfml homepage.

Edit: Ok only I am too stupid for downloading :/

[Laurent]

Isn't the "Latest development snapshot" section of the download page explicit enough?

[kralo9]

Isn't the "Latest development snapshot" section of the download page explicit enough?

Well, it is yes. But why that big table under it? That confused me.
Ok I will try that snapshot and hope it is not crashing anymore when moving lights faster than its speed...
Sorry for my incompetence. Seems I am stupid.

I wanted to add that I like non-oversized-communities line this is, where you even get answers from developers.

[Laurent]

Well, it is yes. But why that big table under it?

The latest sources are just one archive, a single link is enough.
A release has many many pre-compiled packages, thus it requires a big table

[natchos]

Build the API documentation, and read it

// bind a shader
sf::Shader::bind(&shader);

// bind nothing
sf::Shader::bind(NULL);

But what did the old call to ::bind with no arguments do? Did it do the same thing as calling ::bind(NULL)? Since I don't know what the old calls did, I don't know if ::bind(NULL) does the same thing.

[Laurent]

// the old...
shader.bind();

// ...is equivalent to the new...
sf::Shader::bind(&shader);

// the old...
shader.unbind();

// ...is equivalent to the new...
sf::Shader::bind(NULL);

[natchos]

// the old...
shader.bind();

// ...is equivalent to the new...
sf::Shader::bind(&shader);

// the old...
shader.unbind();

// ...is equivalent to the new...
sf::Shader::bind(NULL);

Okay, thank you for clearing that up.

EDIT: is this true for other classes ::bind, such as sf::texture::bind?

[Laurent]

Yes.