Author Topic: New naming convention (Read 85884 times)

Laurent · « **Reply #150 on:** March 13, 2012, 08:54:22 pm »

Quote

you should definitely decide it now

Hum? It's decided, and it's changed now. So what do you mean?

robvleugel · « **Reply #151 on:** March 13, 2012, 09:12:54 pm »

Quote from: "Laurent"

Quote
you should definitely decide it now

Hum? It's decided, and it's changed now. So what do you mean?

You didn't wait for his approval?
Btw I like the new convention, but to be honest I started to get used to the old one and I changed my convention to the same one mainly because of SFML. I realy have to get used to it again.

Oh and I noticed the sf::Mouse:: and sf::Mouse::Left didn't change, whats the reason behind this?

Tank · « **Reply #152 on:** March 13, 2012, 09:58:42 pm »

Constants are still CamelCase. That's something I mentioned earlier what I dislike with the new convention.

Laurent · « **Reply #153 on:** March 13, 2012, 10:29:50 pm »

Quote

Oh and I noticed the sf::Mouse:: and sf::Mouse::Left didn't change, whats the reason behind this?

Classes and constants are still UpperCamelCase.

Quote

Constants are still CamelCase. That's something I mentioned earlier what I dislike with the new convention.

I'm used to UpperCamelCase for constants and I like it. And I won't change that

BMB · « **Reply #154 on:** March 14, 2012, 09:48:30 am »

Can we consider the current git checkout a "final" SFML 2? At least as far as the API? Are there only bug fixes left for SFML 2 final release?

Laurent · « **Reply #155 on:** March 14, 2012, 09:55:07 am »

The current version is supposed to be the final one, yes. I won't even fix bugs, this can be done in SFML 2.1.

So, unless someone comes now and reports a huge flaw in the API, what you see now is the final SFML 2.0.

I'll make a release candidate soon, by the way.

Bigz · « **Reply #156 on:** March 14, 2012, 10:17:19 am »

Quote

[...] what you see now is the final SFML 2.0

So I think it's time for celebration !!!

And a huge thank you for all the work you did ![/quote]

bastien · « **Reply #157 on:** March 14, 2012, 01:26:48 pm »

Do you still plan to rework error handling? If so, when will you do it?

Laurent · « **Reply #158 on:** March 14, 2012, 01:40:18 pm »

Quote

Do you still plan to rework error handling?

Not in SFML 2. In SFML 3, maybe.

Tank · « **Reply #159 on:** March 14, 2012, 02:14:25 pm »

So nothing will be done for -Wshadow...?

Laurent · « **Reply #160 on:** March 14, 2012, 02:23:28 pm »

Quote

So nothing will be done for -Wshadow...?

It will be fixed

Tank · « **Reply #161 on:** March 14, 2012, 02:24:30 pm »

Yuppie

nietaki · « **Reply #162 on:** March 14, 2012, 07:09:35 pm »

Quote from: "Laurent"

I'll make a release candidate soon, by the way.

That's great news! :mrgreen: :mrgreen:

Zephilinox · « **Reply #163 on:** March 15, 2012, 02:54:09 am »

Quote from: "Laurent"

I'll make a release candidate soon, by the way.

awesome, now I can cross compile my projects.

Laurent · « **Reply #164 on:** March 17, 2012, 05:00:54 pm »

I compiled with

Code: [Select]

-Wall -Wextra -Wshadow -pendantic -Wno-long-long
with

Code: [Select]

clang
gcc
mingw32-gcc

and fixed all that was found.

The remaining warnings are all in stb_image.h and stb_image_write.h. I'll see what I can do about them.