I'd like to submit a PR addressing issue #2312 (
Remove defaulted or empty, non-virtual destructors):
https://github.com/SFML/SFML/issues/2312The changes are in the branch
feature/clang-tidy-modernize. I started by introducing a small set of the
modernize-* checks into the
.clang-tidy file to mark constructors/destructors as
=default and
=delete as appropriate, then removed the non-virtual
=default destructors.
Arguably,
=default constructors should be removed as well, since the compiler will generate them anyway.
